Skip to content

Commit

Permalink
refactor: Triggers API required arguments exposed as optional
Browse files Browse the repository at this point in the history
The Trigger API's pipeline function requires two new arguments, the ref and token but was previously exposed as optional arguments.

BREAKING CHANGE: Triggers API pipeline function requires the ref and token
  • Loading branch information
jdalrymple committed May 25, 2019
1 parent 7453779 commit 62e032b
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions src/services/Triggers.ts
Original file line number Diff line number Diff line change
@@ -1,37 +1,40 @@
import { BaseService, RequestHelper } from '../infrastructure';
import { RequestOptions } from '../infrastructure/RequestHelper';

type TriggerId = string | number;

class Triggers extends BaseService {
add(projectId: ProjectId, options: RequestOptions) {
add(projectId: ProjectId, options?: BaseRequestOptions) {
const pId = encodeURIComponent(projectId);

return RequestHelper.post(this, `projects/${pId}/triggers`, options);
}

all(projectId: ProjectId) {
all(projectId: ProjectId, options?: PaginatedRequestOptions) {
const pId = encodeURIComponent(projectId);

return RequestHelper.get(this, `projects/${pId}/triggers`);
return RequestHelper.get(this, `projects/${pId}/triggers`, options);
}

edit(projectId: ProjectId, triggerId: TriggerId, options: RequestOptions) {
edit(projectId: ProjectId, triggerId: TriggerId, options?: BaseRequestOptions) {
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);

return RequestHelper.put(this, `projects/${pId}/triggers/${tId}`, options);
}

remove(projectId: ProjectId, triggerId: TriggerId) {
remove(projectId: ProjectId, triggerId: TriggerId, options?: Sudo) {
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);

return RequestHelper.delete(this, `projects/${pId}/triggers/${tId}`);
return RequestHelper.del(this, `projects/${pId}/triggers/${tId}`, options);
}

show(projectId: ProjectId, triggerId: TriggerId) {
show(projectId: ProjectId, triggerId: TriggerId, options?: Sudo) {
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);

return RequestHelper.get(this, `projects/${pId}/triggers/${tId}`);
return RequestHelper.get(this, `projects/${pId}/triggers/${tId}`, options);
}

pipeline(projectId: ProjectId, ref: string, token: string, options?: Sudo) {
const pId = encodeURIComponent(projectId);

return RequestHelper.post(this, `projects/${pId}/trigger/pipeline`, { ref, token, ...options });
}
}

Expand Down

0 comments on commit 62e032b

Please sign in to comment.