-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
showPagination documentation is innacurate #238
Comments
yup Ill update the docs. Pagination only works when you specify a page, otherwise it will not paginate and return all the results. Does that make sense? Maybe I should return pagination information if you specify maxPages since its less pages then the possible total about of pages |
So ill change it such that if you specify the maxPages or a singular page, then you can see the pagination information. Otherwise its not really helpful since youll be getting back all the results. |
Just pushed up this change! |
## [4.2.6](4.2.5...4.2.6) (2018-11-26) ### Bug Fixes * Update pagination docs and conditions [#238](#238) ([266de00](266de00))
Description
let { data, pagination } = await api.Projects.all({ perPage:40, maxPages:2, showPagination: true });
The
showPagination
option only works if you specify thepage
parameter as well. Otherwise, is ignored.The text was updated successfully, but these errors were encountered: