Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showPagination documentation is innacurate #238

Closed
demetriusnunes opened this issue Nov 23, 2018 · 3 comments
Closed

showPagination documentation is innacurate #238

demetriusnunes opened this issue Nov 23, 2018 · 3 comments

Comments

@demetriusnunes
Copy link

Description

let { data, pagination } = await api.Projects.all({ perPage:40, maxPages:2, showPagination: true });

The showPagination option only works if you specify the page parameter as well. Otherwise, is ignored.

@jdalrymple
Copy link
Owner

yup Ill update the docs. Pagination only works when you specify a page, otherwise it will not paginate and return all the results. Does that make sense? Maybe I should return pagination information if you specify maxPages since its less pages then the possible total about of pages

@jdalrymple
Copy link
Owner

So ill change it such that if you specify the maxPages or a singular page, then you can see the pagination information. Otherwise its not really helpful since youll be getting back all the results.

@jdalrymple
Copy link
Owner

Just pushed up this change!

jdalrymple pushed a commit that referenced this issue Nov 26, 2018
## [4.2.6](4.2.5...4.2.6) (2018-11-26)

### Bug Fixes

* Update pagination docs and conditions [#238](#238) ([266de00](266de00))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants