Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next: new, breaking camelizeKeys behavior is not documented and could be optional? #313

Closed
krische opened this issue May 15, 2019 · 6 comments

Comments

@krische
Copy link

krische commented May 15, 2019

Description
I noticed the new KyRequester functionality is running camelizeKeys on the entire response body. This seems, to me, a very significant change, but I didn't see it mentioned anywhere in the documentation or the change log.

Perhaps there should even be an option to enable/disable that behavior? I could see that change requiring a lot of refactoring for some users.

@jdalrymple
Copy link
Owner

It probably shouldn't be there, at least not without an option. Good catch !

@jdalrymple
Copy link
Owner

Found another problem while making the switch back. Ill get to this before the weekend :)

@jamime
Copy link

jamime commented May 20, 2019

Fixed by ec59c79

@jdalrymple
Copy link
Owner

Yea I havent published the fix yet. Still awaiting on some guidance on this question: #216 (comment)

@jdalrymple
Copy link
Owner

Made the changes, just testing now. It will be optional :)

jdalrymple added a commit that referenced this issue May 23, 2019
feat: Adding the ability to camelizekeys of response body #313
jdalrymple added a commit that referenced this issue May 23, 2019
Fixing #313 - AutoCamelizing of response keys
@jdalrymple
Copy link
Owner

Published in next :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants