Add page URLs #25
Closed
Add page URLs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page switch, and the proper page is recalled upon a browser refresh
|
Thanks, this is awesome. Should pages be 0-indexed or 1-indexed? +1 for not destroying the functionality of the back button, too, I thought that was unavoidable. Also, as a note, you can always amend the previous comment |
|
0-indexed seems appropriate given the project description.
;) And yeah, I just learned that about PRs... I feel silly now. Nice to know for the future though! |
|
87addf7 Thanks! 🏁 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hash-URL to each page, which is updated upon each page switch. The proper page is then recalled upon a browser refresh. This allows the user, for example, to navigate away from the presentation and then return to the slide he was looking at.