Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata 'encoding' to define html document charset #35

Closed
wants to merge 1 commit into from

Conversation

soyrochus
Copy link
Contributor

Cleaver in its current HEAD doesn´t facilitate unicode text, for example German, Dutch, Spanish in UTF-8, symbols etc. I´ve added the medata parameter 'encoding' which allows to specify the charset

@jdan
Copy link
Owner

jdan commented Sep 7, 2013

Thanks for this! I went ahead and made some tweaks and pushed to a new branch, see: 3301a8b

Do you think it's fair to default this new field to utf-8? Everything else looks perfect.

@soyrochus
Copy link
Contributor Author

According to the standard the web browser is supposed to figure it out
itself. But current practice seems to be to put an encoding in by default (
http://htmlpurifier.org/docs/enduser-utf8.html) so your change seems the
correct approach.

Thanks for Cleaver! Its simplicity, but still very complete feature-set,
made me give it a try. I´ll be using it for three separate presentations
next week.

Iwan

On 7 September 2013 07:05, Jordan Scales notifications@github.com wrote:

Thanks for this! I went ahead and made some tweaks and pushed to a new
branch, see: 3301a8bhttps://github.com/jdan/cleaver/commit/3301a8b8abc1d593058e749b60898a776749962e

Do you think it's fair to default this new field to utf-8? Everything
else looks perfect.


Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-23981784
.

http://skitr.com/iwanvanderkleijn.asc
Protect you privacy and identity. Create and share your own
OpenPGPhttp://en.wikipedia.org/wiki/Pretty_Good_Privacykey(s)
Mine are at http://skitr.com/iwanvanderkleijn.asc

@jdan
Copy link
Owner

jdan commented Sep 7, 2013

Awesome, fix landed in 0cd846a. Thanks for your contribution! (and thanks for teaching me about content encodings).

Glad you like the library, keep me posted on your experience using it

@jdan jdan closed this Sep 7, 2013
jdan added a commit that referenced this pull request Sep 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants