-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues/44: Watch for changes in target md-file and recompile the presentation #46
Conversation
nope! it work only for first time, will fix today |
@@ -101,7 +101,7 @@ Cleaver.prototype._loadAssets = function () { | |||
return Q.all([ | |||
helper.load(this.resources, 'resources') | |||
]); | |||
} | |||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know these are JSLint errors but I never put semicolons after function declarations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will squash your commits before merging anyway, so you're free to make a separate commit to remove these. Revert's probably a good option if this was isolated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reverted this commit
Okay not a problem. Ping me when you get a fix in and I'll take a look, thanks! |
It works now. watch messages looks like this: |
This reverts commit ec59268.
return res; | ||
} | ||
|
||
if (process.argv[2] === '--watch' || process.argv[2] === '-w') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it possible to refactor this into the Cleaver prototype? I feel like Cleaver.watch(FILENAME)
makes more sense. Can you call that method without having the program exit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try
Landed in master! I added some slight modifications in aa90d91. Thanks so much for this addition, I'm going to release it today as part of v0.4.0. |
It's awesome! |
Watching file for changes should work now!