Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/44: Watch for changes in target md-file and recompile the presentation #46

Closed
wants to merge 7 commits into from

Conversation

iamstarkov
Copy link
Contributor

Watching file for changes should work now!

@iamstarkov
Copy link
Contributor Author

nope! it work only for first time, will fix today

@@ -101,7 +101,7 @@ Cleaver.prototype._loadAssets = function () {
return Q.all([
helper.load(this.resources, 'resources')
]);
}
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know these are JSLint errors but I never put semicolons after function declarations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I revert this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will squash your commits before merging anyway, so you're free to make a separate commit to remove these. Revert's probably a good option if this was isolated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reverted this commit

@jdan
Copy link
Owner

jdan commented Sep 23, 2013

Okay not a problem. Ping me when you get a fix in and I'll take a look, thanks!

@iamstarkov
Copy link
Contributor Author

It works now.

watch messages looks like this: Regeneration: 21:35 21.990

This reverts commit ec59268.
return res;
}

if (process.argv[2] === '--watch' || process.argv[2] === '-w') {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it possible to refactor this into the Cleaver prototype? I feel like Cleaver.watch(FILENAME) makes more sense. Can you call that method without having the program exit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try

@jdan
Copy link
Owner

jdan commented Oct 2, 2013

Landed in master! I added some slight modifications in aa90d91.

Thanks so much for this addition, I'm going to release it today as part of v0.4.0.

@jdan jdan closed this Oct 2, 2013
@iamstarkov
Copy link
Contributor Author

It's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants