Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Blob SAS URL Never Used as Filepath Never None #154

Merged
merged 1 commit into from
Mar 11, 2024
Merged

BUG: Blob SAS URL Never Used as Filepath Never None #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/aosm/azext_aosm/cli_handlers/onboarding_core_vnf_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,19 @@ def _get_processor_list(self) -> List[AzureCoreArmBuildProcessor | VHDProcessor]
# Instantiate vhd processor
if not self.config.vhd.artifact_name:
self.config.vhd.artifact_name = self.config.nf_name + "-vhd"

if self.config.vhd.file_path:
file_path = Path(self.config.vhd.file_path).absolute()
else:
file_path = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this else statement, do we?

Not a big change, but two lines less is still good :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted. Keeping the else


vhd_processor = VHDProcessor(
name=self.config.vhd.artifact_name,
input_artifact=VHDFileInput(
artifact_name=self.config.vhd.artifact_name,
artifact_version=self.config.vhd.version,
default_config=self._get_default_config(self.config.vhd),
file_path=Path(self.config.vhd.file_path).absolute(),
file_path=file_path,
blob_sas_uri=self.config.vhd.blob_sas_url,
),
)
Expand Down
Loading