Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix -sa in input.jsonc file #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Mar 11, 2024


If no blob name is provided, we take the nf name (sanitised) and append -sa to it. This implementation meant that -sa was being put into the empty input.jsonc file on generate config. To fix this, we move the logic from the post innit to the validate (which is only called on build)

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jordlay jordlay requested a review from sunnycarter as a code owner March 11, 2024 09:54
@jordlay jordlay changed the title moved blob sa name to validate to fix bug BUG: Fix -sa in input.jsonc file Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant