Remove imageName from deployparameters #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyclam
reviewed
Mar 12, 2024
| @@ -72,7 +72,7 @@ def _get_processor_list(self) -> List[AzureCoreArmBuildProcessor | VHDProcessor] | |||
| arm_input = ArmTemplateInput( | |||
| artifact_name=arm_template.artifact_name, | |||
| artifact_version=arm_template.version, | |||
| default_config=None, | |||
| default_config={"imageName": self.config.nf_name + "Image"}, | |||
There was a problem hiding this comment.
What happens if default_config is passed in and gives imageName a different value?
There was a problem hiding this comment.
it can't, we were previously passing no default config. But in this specific case of azure core vnfs, we are now giving imageName. This doesnt come from anywhere else except us giving it here
| @@ -146,6 +146,9 @@ def _get_default_config(self, vhd) -> Dict[str, Any]: | |||
| default_config.update({"image_hyper_v_generation": "V1"}) | |||
| if vhd.image_api_version: | |||
| default_config.update({"image_api_version": vhd.image_api_version}) | |||
|
|
|||
| # Add imageName | |||
| default_config["imageName"] = self.config.nf_name + 'Image' | |||
There was a problem hiding this comment.
Why do we have this and (basically) the same code on line 75?
There was a problem hiding this comment.
One is for the vhd and one is for the arm template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify the CLI, we are removing imageName from the deployParameters.
This means:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.