Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Improvements for health_status test helper #833

Closed
jdeathe opened this issue Jun 22, 2019 · 0 comments · Fixed by #858
Closed

Improvements for health_status test helper #833

jdeathe opened this issue Jun 22, 2019 · 0 comments · Fixed by #858
Milestone

Comments

@jdeathe
Copy link
Owner

jdeathe commented Jun 22, 2019

  1. Remove this as it's redundant.
    https://github.com/jdeathe/centos-ssh/blob/2.6.0/test/health_status#L242-L245

  2. Can disown immediately and close of unused file descriptors here.
    https://github.com/jdeathe/centos-ssh/blob/2.6.0/test/health_status#L225-L234

  3. Improve options handling; long options should work without the need for =.
    https://github.com/jdeathe/centos-ssh/blob/2.6.0/test/health_status#L120-L167

  4. More consistent error/info messages.

  5. Add set -e

@jdeathe jdeathe added this to the 2.6.1 milestone Jun 22, 2019
@jdeathe jdeathe changed the title Remove impossible health_status "starting" Improvements for health_status test helper Jun 22, 2019
jdeathe added a commit that referenced this issue Sep 14, 2019
CLOSES #833: Updates health_status test helper and fixes timeout validation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant