Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OG-USA version of taxcalc/parameters.py and taxcalc/policy.py #10

Closed
wants to merge 19 commits into from
Closed

Implement OG-USA version of taxcalc/parameters.py and taxcalc/policy.py #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
97e9c43
Sketches out PB API
Mar 9, 2018
d6f9494
Add explanation for intermediate ParametersBaseOGUSA class
Mar 9, 2018
06ec69f
Fill in parameter reading API a little more
Mar 15, 2018
1898d48
Add further examples for populating the default values
Mar 15, 2018
88203a6
merge with ogusa
Mar 19, 2018
efd7797
Reformat strings to comply with JSON specs
Mar 20, 2018
a14f6df
Minimum viable solution
Mar 20, 2018
9a7c033
Remove extra expand logic and indexing logic
Mar 20, 2018
93f2856
Remove more CPI logic and experiment with year options
Mar 20, 2018
6a09b23
Fix how year is set, remove extra functions and fix simple_eval
Mar 20, 2018
979e625
Rename Specs to Specifications
Apr 4, 2018
a5fcfa0
Rename implement_reform to update_specifications
Apr 4, 2018
9824784
Rename reform_{errors|warnings} to {errors|warnings}
Apr 4, 2018
7421ebc
Fix frisch typo (0.4 --> 0.04)
Apr 4, 2018
ec734e3
Update reform_warnings_errors
Apr 4, 2018
7a6f7e5
Add JSON_START_YEAR back to Specifications class
Apr 4, 2018
7bbaed9
Editor fixed some new line/formatting issues on save
Apr 4, 2018
acbc377
Add first set of tests for pb_api.py
Apr 4, 2018
8396120
Fix typo in pb_api.estimate_paramters fn
Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 11 additions & 32 deletions ogusa/default_parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
'''
Not in here:
1) BW = int(TC_LAST_YEAR - start_year + 1)
How can I:
i) check things like that lambdas.sum=1? Length J
ii) what to do with world_int_rate dictionary?
iii) Checking tG1 vs tG2 vs T
iv) Check that tau_bq is of length J
v) How to choose set of test parameters (small state space) easily
vi) Checking consistency of baseline_spending with other options
vii) how handle dask parameters?
viii) How handle baseline boolean? paths?
'''
{
"frisch": {
"long_name": "Frisch elasticity of labor supply",
Expand All @@ -20,7 +7,7 @@ viii) How handle baseline boolean? paths?
"col_label": "",
"boolean_value": false,
"integer_value": false,
"value": [0.4],
"value": [0.04],
"range": {"min": 0.02, "max": 0.06},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
Expand Down Expand Up @@ -81,7 +68,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": false,
"integer_value": true,
"value": [320],
"range": {"min": S, "max": 1000},
"range": {"min": "S", "max": 1000},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand Down Expand Up @@ -111,7 +98,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": false,
"integer_value": true,
"value": [20],
"range": {"min": 0, "max": ending_age-1},
"range": {"min": 0, "max": "ending_age - 1"},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand All @@ -126,7 +113,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": false,
"integer_value": false,
"value": [100],
"range": {"min": starting_age + 1, "max": 120},
"range": {"min": "starting_age + 1", "max": 120},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand Down Expand Up @@ -276,7 +263,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": false,
"integer_value": true,
"value": [20],
"range": {"min": 0, "max": T/2},
"range": {"min": 0, "max": "T / 2"},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand Down Expand Up @@ -516,7 +503,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": true,
"integer_value": false,
"value": [false],
"range": {"min": , "max": },
"range": {"min": "", "max": ""},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand All @@ -531,7 +518,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": true,
"integer_value": false,
"value": [false],
"range": {"min": , "max": },
"range": {"min": "", "max": ""},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand All @@ -546,7 +533,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": true,
"integer_value": false,
"value": [true],
"range": {"min": , "max": },
"range": {"min": "", "max": ""},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand All @@ -561,7 +548,7 @@ viii) How handle baseline boolean? paths?
"boolean_value": true,
"integer_value": false,
"value": [false],
"range": {"min": , "max": },
"range": {"min": "", "max": ""},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
Expand All @@ -576,18 +563,10 @@ viii) How handle baseline boolean? paths?
"boolean_value": true,
"integer_value": false,
"value": [false],
"range": {"min": , "max": },
"range": {"min": "", "max": ""},
"out_of_range_minmsg": "",
"out_of_range_maxmsg": "",
"out_of_range_action": "stop",
"compatible_data": {"puf": true, "cps": true}
},
}
}


'constant_rates': False, 'analytical_mtrs': False,
'age_specific': True, 'user_params': user_params,
'guid': '_2017Law_dask', 'reform': reform, 'run_micro': True,
'small_open': small_open, 'budget_balance': False,
'baseline_spending': True, 'client': client,
'num_workers': num_workers
Loading