Fixing some of the issues pointed out by reviewer shoyokota.

jderber-NOAA · Jan 5, 2024 · 593ed20 · 593ed20
1 parent 7cf1df5
commit 593ed20
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 293 deletions.
diff --git a/src/gsi/control_vectors.f90 b/src/gsi/control_vectors.f90
@@ -415,8 +415,8 @@ subroutine init_anacv
     write(6,*) myname_,': ALL CONTROL VARIABLES    ', nrf_var
 end if
 lcalc_gfdl_cfrac = .false.
-c2sset_flg = .true.   ! set to true in setup.  set to false after first (only) call to ensctl2state_set
-e2sset_flg = .true.   ! set to true in setup.  set to false after first (only) call to init_anacv
+c2sset_flg = .true.   ! set to true in setup.  set to false after first (only) call to c2sset
+e2sset_flg = .true.   ! set to true in setup.  set to false after first (only) call to ensctl2state_set
 
 end subroutine init_anacv
 subroutine final_anacv

diff --git a/src/gsi/ensctl2state_ad.f90 b/src/gsi/ensctl2state_ad.f90
diff --git a/src/gsi/general_commvars_mod.f90 b/src/gsi/general_commvars_mod.f90
@@ -123,8 +123,6 @@ subroutine init_general_commvars
       integer(i_kind) lnames2(2,2*nsig+1)
       character(len=64) names3(1,4*nsig+1)
       integer(i_kind) lnames3(1,4*nsig+1)
-      character(len=64) names4(2,nsig)
-      integer(i_kind) lnames4(2,nsig)
 
 
 !  create general_sub2grid structure variable s2g_raf, which is used in sub2grid.f90

diff --git a/src/gsi/glbsoi.f90 b/src/gsi/glbsoi.f90
@@ -211,7 +211,6 @@ subroutine glbsoi
 ! Set cost function
   call create_jfunc
 
-! stop
   lunit=0
   lunix=0
   call isetprm('MXMSGL',400000)

diff --git a/src/gsi/gsi_files.cmake b/src/gsi/gsi_files.cmake
@@ -157,7 +157,6 @@ ens_spread_mod.f90
 ensctl2model.f90
 ensctl2model_ad.f90
 ensctl2state.f90
-ensctl2state_ad.f90
 evaljgrad.f90
 evaljo.f90
 evalqlim.f90