Express 4 fail

[mrzepinski]

The code has been updated and merged: 9822790

but in npm repositories is still old version.

[LinusU]

Yes, please bump version to 0.4.1 and npm publish!

[mrzepinski]

@LinusU My update is here: #104

I thknk it should be 0.5.0 version. It's better to tell others about Express 4.x i compatible now.

[LinusU]

I don't think so, the api hasn't changed in any way and no backwards incompatible changes have been introduced. This is just PATCH not MINOR, http://semver.org/.

MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

[mrzepinski]

@LinusU Ok, I closed #104 pull-request and here is a valid commit: #105

[nevi-me]

Would this resolve issues where we're getting session errors? I upgraded to Express 4.0 by mistake, and even though I reverted back to 3.x I still get errors.

[mrzepinski]

@nevi-me Fix is here, commited to this repository, but version in NPM repositories is without it.

[LinusU]

@mrzepinski Thanks!

@nevi-me This is only fixing an issue with Express 4.0. If you have downgraded then your issue is something else.

You can check if you are effected by looking at express.session. If it is undefined (as it is in >= 4.0.0) then you need this fix. If it exists, then your problem lies elsewhere.

[nevi-me]

@LinusU yea my issue was with secure cookies, it worked prior to express 3.4.8 in my local machine, but I think something that changed that wasn't setting cookies, after disabling secure cookies in development that fixed the error, so it wasn't related to connect-mongo. I also seem to no longer get TTL index errors now

Would also vote for a version bump and npm publish

[kentcdodds]

+1 on this issue... @kcbanner where are you?

[mrzepinski]

Do I have appropriate rights to do that? I have never published to NPM :)

[kentcdodds]

Sorry @mrzepinski, I mistakenly @ mentioned you when I meant to reference @kcbanner :)

[Myztiq]

+1

[azhang]

+1. However I just tried it and still get the middleware error from express4. Maybe I'm using it wrong - it'd be great if you could update the readme too. Thanks

[pasupulaphani]

Kindly update the readme section for express4