24 Hour Time And Meridian = True Does Not Work Correctly

[chodges]

I have found that the time picker is not handling 24 hour time correctly when using the meridian:

When the time is greater than 11 you will notice that the meridian is ALWAYS AM when it should be PM.

So I ended up having to edit the SetTime method to the following:

this.hour = parseInt(timeArray[0], 10);
  this.minute = parseInt(timeArray[1], 10);
  this.second = parseInt(timeArray[2], 10);

  if (isNaN(this.hour)) {
    this.hour = 0;
  }
  if (isNaN(this.minute)) {
    this.minute = 0;
  }

 if (this.showMeridian) {
  if (this.hour >= 12) {

    if(this.hour > 12)
      this.hour -= 12;

  this.meridian = 'p';
 } else if (this.hour < 1) {
  this.hour = 12;
 }

Would love to get this fix rolled into a future release.

Thanks.

[mrhota]

I'm not sure I understand: Are you saying the timepicker is able to display 24-hour-like times when showMeridian is true?

[chodges]

I apologize if its unclear. What I'm saying is that even when I set showMeridian to true the time continues to display in 24-hour format rather than 12 hour format with the meridian. The code above that I submitted fixes the problem.

[mrhota]

It sounds like you might be using old code, since what you're saying means that 12-hour time would have to be completely broken. But, based on my own experience, 12-hour time works fine.

I just released a new version supporting bootstrap 3. You might want to see if that fixes the issues you saw.

[chodges]

I will check the new release and remember I sent in that bug well over a year ago so its very possible that bug was in old code.

[mrhota]

Thanks for taking the time. Hopefully, you'll find the new code is more useful and correct, but don't hesitate to gripe if something's still broken.

[chodges]

Hahah. Thanks will do and thank you for the great work you guys have done on this library.