Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timepicker not initializing properly if 'input-group' and 'bootstrap-timepicker' classes out of order #279

Closed
mrhota opened this issue Aug 6, 2015 · 1 comment
Closed

timepicker not initializing properly if 'input-group' and 'bootstrap-timepicker' classes out of order #279

mrhota opened this issue Aug 6, 2015 · 1 comment
Labels
bug high importance

Comments

@mrhota
Copy link
Collaborator

mrhota commented Aug 6, 2015

jQuery's hasClass method accepts one and only one class as a string parameter. Line 55 of bootstrap-timepicker.js calls hasClass('input-group bootstrap-timepicker'), which fails if the classes are declared in a different order. Use two calls to hasClass instead.
mrhota pushed a commit that referenced this issue Aug 6, 2015
@mastodonfarm
Fixes critical defect #279
33d9d2c 
I changed a test to use differently-ordered bootstrap classes. Tests
failed before the fix, and everything passes with the fix. Good.
@mrhota
Copy link
Collaborator Author

mrhota commented Aug 6, 2015

Fixed by 33d9d2c

@mrhota mrhota closed this as completed Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high importance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrhota