Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty css #2818

Closed
wants to merge 12 commits into from
Closed

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Dec 3, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • 更新了 Empty 组件的标题和描述,提高了内容的清晰度。
    • 增加了对组件版本的支持,标记为 v14
  • 样式
    • 改进了日历卡片的样式,增强了非交互状态的视觉指示。
    • 更新了 Empty 组件的样式,包括标题和描述的字体大小及颜色。
  • 文档
    • 更新了 Empty 组件的文档,提供了更清晰的使用示例和属性说明。

Copy link

coderabbitai bot commented Dec 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此拉取请求包含对多个文件的修改,主要集中在 src/config.json 文件中新增和更新组件属性,特别是为 EmptyCountDownPagination 组件添加了 v14 属性。此外,还对多个 Empty 组件的演示文件进行了文本内容的更新,增强了用户界面的可读性和描述性。在样式文件中,针对日历卡的光标样式和 RTL 布局进行了调整,以改善用户体验。

Changes

文件路径 更改摘要
src/config.json EmptyCountDownPagination 组件添加 v14 属性。
src/packages/calendarcard/calendarcard.scss .prev.next.disabled 类添加 cursor: not-allowed; 样式,并调整 RTL 布局的边距。
src/packages/empty/__test__/empty.spec.tsx 更新 CSS 类选择器 .nut-empty-actions.nut-empty-actions-base,影响两个断言。
src/packages/empty/demos/h5/demo1.tsx 更新 Empty 组件的 titledescriptionactions 属性。
src/packages/empty/demos/h5/demo2.tsx 为第一个 Empty 组件添加新的 title 属性,更新 description 属性。
src/packages/empty/demos/h5/demo3.tsx 更新 Empty 组件的 description 属性。
src/packages/empty/demos/h5/demo4.tsx 更新 TabPaneEmpty 组件的标题以改善本地化。
src/packages/empty/demos/h5/demo6.tsx 更改 Button 的标签文本,从 "重试" 更改为 "刷新重试"。
src/packages/empty/demos/taro/demo1.tsx 更新 Empty 组件的 titledescriptionactions 属性。
src/packages/empty/demos/taro/demo2.tsx 为第一个 Empty 组件添加新的 title 属性,更新 description 属性。
src/packages/empty/demos/taro/demo3.tsx 更新 Empty 组件的 description 属性。
src/packages/empty/demos/taro/demo4.tsx 更新 TabPaneEmpty 组件的标题以改善本地化。
src/packages/empty/demos/taro/demo6.tsx 更改 Button 的标签文本,从 "重试" 更改为 "刷新重试"。
src/packages/empty/doc.en-US.md 更新 CSS 变量的描述和默认值,特别是 --nutui-empty-title-margin-top--nutui-empty-title-line-height
src/packages/empty/doc.md 扩展文档以包含组件属性的详细说明和默认值。
src/packages/empty/doc.taro.md 更新 CSS 变量的默认值,特别是 --nutui-empty-title-margin-top--nutui-empty-title-line-height
src/packages/empty/doc.zh-TW.md 更新文档中的属性表描述和格式,以提高一致性。
src/packages/empty/empty.scss 更新 .nut-empty-title.nut-empty-description 类的样式,添加新的 .nut-empty-actions-base 类。
src/packages/empty/empty.taro.tsx 更新 Empty 组件中动作部分的类名以动态包含 size 属性。
src/packages/empty/empty.tsx 更新 Empty 组件中动作部分的类名以动态包含 size 属性。
src/styles/variables.scss 更新多个 CSS 变量的默认值,特别是颜色和字体大小属性。

Possibly related PRs

Suggested labels

size/M

Suggested reviewers

  • oasis-cloud

兔子欢跳庆新篇,
组件更新真不凡。
文档清晰更易读,
用户体验乐无边。
让我们一起欢呼吧,
版本更新真精彩! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 116fbbf and 4237062.

📒 Files selected for processing (21)
  • src/config.json (1 hunks)
  • src/packages/calendarcard/calendarcard.scss (1 hunks)
  • src/packages/empty/__test__/empty.spec.tsx (1 hunks)
  • src/packages/empty/demos/h5/demo1.tsx (1 hunks)
  • src/packages/empty/demos/h5/demo2.tsx (1 hunks)
  • src/packages/empty/demos/h5/demo3.tsx (1 hunks)
  • src/packages/empty/demos/h5/demo4.tsx (1 hunks)
  • src/packages/empty/demos/h5/demo6.tsx (1 hunks)
  • src/packages/empty/demos/taro/demo1.tsx (1 hunks)
  • src/packages/empty/demos/taro/demo2.tsx (1 hunks)
  • src/packages/empty/demos/taro/demo3.tsx (1 hunks)
  • src/packages/empty/demos/taro/demo4.tsx (1 hunks)
  • src/packages/empty/demos/taro/demo6.tsx (1 hunks)
  • src/packages/empty/doc.en-US.md (1 hunks)
  • src/packages/empty/doc.md (1 hunks)
  • src/packages/empty/doc.taro.md (1 hunks)
  • src/packages/empty/doc.zh-TW.md (1 hunks)
  • src/packages/empty/empty.scss (1 hunks)
  • src/packages/empty/empty.taro.tsx (1 hunks)
  • src/packages/empty/empty.tsx (1 hunks)
  • src/styles/variables.scss (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x Target branch 3.x label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant