Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support open more entries in update-taro-entry #2848

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: support open more entries in update-taro-entry #2848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/rn/update-taro-entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ const path = require('path')
const config = require('../../src/config.json')
const param = process.env.C

// C=radio pnpm dev:taro:jdharmonycpp
// C=radio pnpm dev:taro:jdharmonycpp or C=radio,button,cell pnpm dev:taro:jdharmonycpp
function specialComponent(name) {
return param && name.toLowerCase() == param.toLowerCase()
const entries = param.split(',').map((i) => i.toLowerCase())
return entries.includes(name.toLowerCase())
Comment on lines +9 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

建议添加输入验证逻辑

specialComponent 函数在处理 param 时缺少必要的输入验证。当 param 为 undefined、null 或空字符串时，split 操作可能会导致错误。

建议添加以下改进：

 function specialComponent(name) {
+  if (!param) return false;
   const entries = param.split(',').map((i) => i.toLowerCase())
   return entries.includes(name.toLowerCase())
 }

Committable suggestion skipped: line range outside the PR's diff.

}

// 已适配组件对象
Expand Down
Loading