Skip to content

Conversation

irisSong
Copy link
Collaborator

@irisSong irisSong commented Jun 9, 2025

…nto feat_v3.x

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Bug Fixes
    • 修复了切换组件在点击时可能重复触发 onChange 的问题,现在只会异步调用一次 onChange

Copy link

coderabbitai bot commented Jun 9, 2025

Walkthrough

本次变更移除了在 onClick 事件处理器中对 onChange(!value) 的同步调用,现在仅在异步的 try-catch 块中 await 调用 onChange(!value),确保 onChange 只被异步调用一次,其余控制流程保持不变。

Changes

文件/分组 变更摘要
src/packages/switch/switch.taro.tsx 移除了 onClick 处理器中对 onChange(!value) 的同步调用,仅保留异步 await 调用。

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant SwitchComponent
  participant onChangeHandler

  User->>SwitchComponent: 点击 Switch
  SwitchComponent->>SwitchComponent: 设置 loading 状态
  alt 异步调用 onChange
    SwitchComponent->>onChangeHandler: await onChange(!value)
    onChangeHandler-->>SwitchComponent: 返回(成功或失败)
    SwitchComponent->>SwitchComponent: 更新内部值
  end
Loading

Possibly related PRs

Suggested reviewers

  • xiaoyatong
  • oasis-cloud

Poem

兔子点点小开关,
异步流转不慌乱。
同步调用已移除,
只留 await 在心间。
代码清爽如春风,
小兔欢跳乐无边!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0eaabc and 5439dea.

📒 Files selected for processing (1)
  • src/packages/switch/switch.taro.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/packages/switch/switch.taro.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: test
  • GitHub Check: build
  • GitHub Check: lint
  • GitHub Check: test
  • GitHub Check: update-labels
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) labels Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (d0eaabc) to head (5439dea).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3259   +/-   ##
==========================================
  Coverage      87.75%   87.75%           
==========================================
  Files            290      290           
  Lines          19111    19111           
  Branches        2937     2938    +1     
==========================================
+ Hits           16770    16771    +1     
+ Misses          2336     2335    -1     
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@irisSong irisSong requested a review from xiaoyatong June 9, 2025 08:05
@irisSong irisSong linked an issue Jun 9, 2025 that may be closed by this pull request
@xiaoyatong xiaoyatong merged commit 838cffb into jdf2e:feat_v3.x Jun 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch会触发两次

3 participants