-
Notifications
You must be signed in to change notification settings - Fork 284
fix: 为兼容 cpp 版本做的暂时性的牺牲改动 #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. Walkthrough本次变更主要移除了 Taro 端 Dialog、Overlay 和 Popup 组件中的 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dialog/Overlay/Popup Component
User->>Dialog/Overlay/Popup Component: 设置 visible/innerVisible
Dialog/Overlay/Popup Component-->>Dialog/Overlay/Popup Component: 直接切换 display: 'block'/'none'
Note right of Dialog/Overlay/Popup Component: 无过渡动画
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x_cpp #3325 +/- ##
==============================================
Coverage 88.13% 88.14%
==============================================
Files 290 290
Lines 19113 19113
Branches 2960 2961 +1
==============================================
+ Hits 16846 16847 +1
+ Misses 2262 2261 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
@nutui/nutui-react-taro
的版本号至 3.0.18-cpp.beta.0。样式