Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for spinner to be hidden before clicking #1

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

mightyquack
Copy link
Contributor

It was crashing trying to click on the login box before the spinner disappeared. This will now wait for the Spinner to be invisible and the Login button to be clickable.

Fixes this error:
selenium.common.exceptions.ElementClickInterceptedException: Message: element click intercepted: Element ... is not clickable at point (1849, 28). Other element would receive the click:

...

@jdholtz
Copy link
Owner

jdholtz commented Apr 17, 2022

Thanks! I wonder if this should be done to the check-in function that uses the same method...

Since you used EC.element_to_be_clickable, from my understanding, you wouldn't need to wait for the spinner to disappear because the driver wouldn't try to click the element until it is able to.

Also, it might be better to use EC.element_to_be_clickable everywhere instead of EC.presence_of_element_located to mitigate any more errors like this one.

I am not very experienced with selenium though, so I could be totally wrong.

@mightyquack
Copy link
Contributor Author

mightyquack commented Apr 17, 2022 via email

@jdholtz jdholtz merged commit 4b1d7e1 into jdholtz:master Apr 17, 2022
jdholtz added a commit that referenced this pull request Apr 30, 2022
The latest version of undetected_chromedriver fixes running multiple
browsers at the same time.

Also, the latest version of undetected_chromedriver adds the
--no-sandbox flag by default, so that is not needed. The
--disable-dev-shm-usage flag might need to be added when I add a Docker
implementation, but for right now it is useless.
@jdholtz
Copy link
Owner

jdholtz commented Apr 30, 2022

Accidentally referenced this in a commit message. It was meant for #2. Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants