Fix process handling on Windows and Mac #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the 'spawn' method, each class is pickled. However, the Process object cannot be pickled and therefore cannot be referenced as an instance variable. Due to these limitations, the Process ID is now kept track of and killed using os.kill. os.waitpid is used as well to prevent zombie processes.
This functionality isn't in undetected_chromedriver yet (although I might make a PR). Therefore, this has to be handled within this script. There should no longer be any zombie processes left from this script.
terminate Windows does not leave zombie processes after os.kill() is called. Therefore, during waitpid() it will throw a ChildProcessError as the PID is not a child of the parent process. To fix it, the exception can simply be caught and passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118 and #119.
When multiprocessing uses the 'spawn' start method, the Process object cannot be an instance variable as it can't be pickled. This PR changes the previous implementation to only keep track of the Process ID. Then, the
osmodule is used to kill the process when we need to.Additionally,
os.waitpid()is used (isn't needed in Windows) to ensure killed processes don't turn into zombie/defunct processes. Now, no zombie processes are left from this script.