No longer notifies NoneNone for lap child
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdholtz
reviewed
Jan 23, 2024
| @@ -9,6 +9,7 @@ repos: | |||
| - id: codespell | |||
| additional_dependencies: | |||
| - tomli | |||
| exclude: utils/airport_timezones.json | |||
There was a problem hiding this comment.
Was this necessary for you? I have this configuration in pyproject.toml so codespell should exclude it without needing this. I would prefer to have this in only one place, not both as it will be easier to add/remove configurations.
There was a problem hiding this comment.
It was triggering for me if i run pre-commit run --all-files, but I'm happy to remove it if you don't want it there.
There was a problem hiding this comment.
Ah, yes I get the same issue. Seems to be a bug with codespell then.
|
Thanks for this PR! Changed the base to the develop branch to stay in line with the release cycles of this script. Just one comment to address and I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
No longer says