Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry mechanism for 429 Too Many Requests and 500 Internal Server Error #311

Merged
merged 4 commits into from
Nov 3, 2024
Merged

Add retry mechanism for 429 Too Many Requests and 500 Internal Server Error #311

merged 4 commits into from
Nov 3, 2024

Conversation

dmytrokoren
Copy link
Contributor

No description provided.

@dmytrokoren
Copy link
Contributor Author

@jdholtz lets review and merge.

@dmytrokoren dmytrokoren changed the title Add retry mechanism for 429 Too Many Requests errors Add retry mechanism for 429 Too Many Requests and 500 Internal Server Error Oct 18, 2024
jdholtz
jdholtz approved these changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@jdholtz jdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating out this change to a separate PR. I updated the tests to mock the sleep calls (so the unit tests don't take 20+ seconds) and it will be a part of next release.

lib/reservation_monitor.py Show resolved Hide resolved
@jdholtz jdholtz merged commit ee0e4a4 into jdholtz:develop Nov 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdholtz jdholtz jdholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmytrokoren @jdholtz