Fix header url #314
Merged
Fix header url #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! I changed the PR to merge to the develop branch and will make a release with this fix soon. |
achandy
reviewed
Nov 2, 2024
| @@ -20,7 +20,7 @@ | |||
| BASE_URL = "https://mobile.southwest.com" | |||
| LOGIN_URL = BASE_URL + "/api/security/v4/security/token" | |||
| TRIPS_URL = BASE_URL + "/api/mobile-misc/v1/mobile-misc/page/upcoming-trips" | |||
| HEADERS_URL = BASE_URL + "/api/chase/v2/chase/offers" | |||
| HEADERS_URL = BASE_URL + "/api/mobile-air-booking/v1/mobile-air-booking/feature/shopping-details" | |||
There was a problem hiding this comment.
Did southwest change its endpoint on their end?
There was a problem hiding this comment.
I’m not sure as I didn’t look much into it, but sometimes Southwest will change the requests that are sent when you load the homepage. That’s my best guess as to what happened here. The old URL isn’t being loaded with the homepage, but rather this URL now.
A better fix to this could potentially be to look for the headers in the request instead of checking for a specific URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313 per diff from issue thread