Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes screenshot generator to work for generating all languages at once #5

Conversation

kdmukai
Copy link

@kdmukai kdmukai commented Sep 21, 2024

Description

Running the screenshot generator for all languages would succeed on the first language, but then throw an exception when trying to restart a Toast thread. Beside that, other issues occurred due to how the first run through changes the Controller state and does not reset it for the next language's run.

The visual diff here is hard to digest, but the changes are actually very minor. The Controller setup and the list of target Views (screenshot_sections) are just wrapped into their own method that gets called for each language to ensure a clean state and no already-instantiated / already-running Toasts.

Sig type and script type are explicitly set in Settings, otherwise the related selection Views during xpub export won't render (the first test run sets each to a single option so a naive follow-up run will cause those Views to auto-skip themselves since there are no choices to make).


This pull request is categorized as a:

  • Bug fix

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

@kdmukai kdmukai marked this pull request as draft September 21, 2024 15:40
I instead submitted them as a PR to the main repo's `dev` branch: SeedSigner#613
@kdmukai kdmukai marked this pull request as ready for review September 21, 2024 17:08
@jdlcdl jdlcdl merged commit e1d8fb6 into jdlcdl:kdmukai/initial_multilanguage Sep 30, 2024
@jdlcdl
Copy link
Owner

jdlcdl commented Sep 30, 2024

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants