Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multicast responses not being sent out on all interfaces #26

Closed
wants to merge 2 commits into from
Closed

Fix multicast responses not being sent out on all interfaces #26

wants to merge 2 commits into from

Conversation

Electronics
Copy link

Adding the multicast socket options to an IPv4 interface would sometimes throw an "A socket operation was attempted to an unreachable host.".

This was fixed by binding the multicast option to the address.

jdomnitz
jdomnitz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@jdomnitz jdomnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

jdomnitz
jdomnitz requested changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@jdomnitz jdomnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There don't appear to be any functional changes with this commit

@jdomnitz
Copy link
Owner

I'll rebase and merge the functional changes

@jdomnitz
Copy link
Owner

jdomnitz commented Jul 2, 2024

Refactored and pushed. Thank you!

@jdomnitz jdomnitz closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdomnitz jdomnitz jdomnitz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Electronics @jdomnitz