Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces IMulticastService and IServiceDiscovery #7

Merged
merged 1 commit into from
May 17, 2023
Merged

Add interfaces IMulticastService and IServiceDiscovery #7

merged 1 commit into from
May 17, 2023

Conversation

mrx-00
Copy link

@mrx-00 mrx-00 commented May 12, 2023

Unit testing frameworks (e.g. Moq or FakeItEasy) can mock referenced classes in order to achieve a specific behaviour. In order to do so, the classes need to provide an overridable implementation. This can be achieved by either providing an interface or declaring members virtual.

This PR adds the interfaces IMulticastService and IServiceDiscovery to be able to mock the instances for unit testing.

Copy link
Owner

@jdomnitz jdomnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spelling catches in addition to the code changes

@jdomnitz jdomnitz merged commit 2016ad6 into jdomnitz:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants