Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: do not forcefully create venv #1058

Merged
merged 1 commit into from
Dec 3, 2023
Merged

python: do not forcefully create venv #1058

merged 1 commit into from
Dec 3, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 3, 2023 •
edited
Loading

Fixes #875

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2023 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ab4fd4b) 86.17% compared to head (8aee37e) 86.06%.

Files Patch % Lines
src/plugins/core/python.rs 17.24% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   86.17%   86.06%   -0.11%     
==========================================
  Files         134      134              
  Lines       12366    12373       +7     
==========================================
- Hits        10656    10649       -7     
- Misses       1710     1724      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit b4f2a1d into main Dec 3, 2023
15 of 17 checks passed
@jdx jdx deleted the python branch December 3, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: don't overwrite virtualenv path if it exists and is not a virtualenv
1 participant
@jdx