Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use vendored openssl crate feature to mitigate missing headers #1693

Closed
wants to merge 2 commits into from

Conversation

wheinze
Copy link
Contributor

@wheinze wheinze commented Feb 21, 2024

Hopefully fixes these kinda errors: https://github.com/jdx/mise/actions/runs/7996715229/job/21839765074

Not quite sure yet, but found hints that openssl headers might be missing. Using the vendored feature of openssl crate, these should be used from openssl-src.

@jdx
Copy link
Owner

jdx commented Feb 22, 2024

we're already using this I think:

- run: scripts/build-tarball.sh mise --release --features openssl/vendored --target ${{matrix.target}}

not sure what's going on here but it looks like maybe a bug around the cc crate

@wheinze
Copy link
Contributor Author

wheinze commented Feb 22, 2024

we're already using this I think:

- run: scripts/build-tarball.sh mise --release --features openssl/vendored --target ${{matrix.target}}

not sure what's going on here but it looks like maybe a bug around the cc crate

oh, i c - kk, then i'll close this one ;)

@wheinze wheinze closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants