Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying asdf plugins with full urls #3067

Merged
merged 3 commits into from
Nov 20, 2024
Merged

feat: allow specifying asdf plugins with full urls #3067

merged 3 commits into from
Nov 20, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 17, 2024

Fixes #3063

This allows installing asdf plugins directly like mise install asdf:https://github.com/jdx/mise-tiny or mise install asdf:jdx/mise-tiny

@jdx jdx force-pushed the plugins-config branch 5 times, most recently from bb8c63c to d8600e0 Compare November 17, 2024 21:24
@jdx jdx changed the title fix: allow plugins in config to override core plugins fix: allow specifying asdf plugins with full urls Nov 17, 2024
@jdx jdx changed the title fix: allow specifying asdf plugins with full urls feat: allow specifying asdf plugins with full urls Nov 17, 2024
@jdx jdx marked this pull request as ready for review November 17, 2024 21:27
Copy link

codacy-production bot commented Nov 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% 85.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2566f84) 21464 16925 78.85%
Head commit (f729ebb) 21463 (-1) 16914 (-11) 78.81% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3067) 40 34 85.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx force-pushed the plugins-config branch 12 times, most recently from a630dfc to b4f84ee Compare November 18, 2024 20:46
Copy link

github-actions bot commented Nov 18, 2024

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 14.9 ± 0.3 14.2 17.3 1.01 ± 0.06
mise-2024.11.18 x -- echo 14.7 ± 0.8 14.0 26.9 1.00
mise x -- echo 14.9 ± 0.3 14.2 16.7 1.01 ± 0.06

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 11.7 ± 0.3 11.2 13.2 1.01 ± 0.03
mise-2024.11.18 env 11.5 ± 0.2 11.0 12.7 1.00
mise env 11.7 ± 0.3 11.1 13.8 1.01 ± 0.03

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 11.6 ± 0.2 11.1 12.4 1.02 ± 0.03
mise-2024.11.18 hook-env 11.4 ± 0.2 10.9 13.0 1.00
mise hook-env 11.6 ± 0.2 11.1 13.4 1.02 ± 0.03

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 11.9 ± 0.2 11.5 12.9 1.02 ± 0.03
mise-2024.11.18 ls 11.7 ± 0.2 11.3 13.2 1.00
mise ls 11.9 ± 0.2 11.4 12.9 1.01 ± 0.03

@jdx jdx force-pushed the plugins-config branch 7 times, most recently from f305884 to e3f3716 Compare November 20, 2024 19:36
@jdx jdx force-pushed the plugins-config branch 5 times, most recently from a131f98 to b5cce25 Compare November 20, 2024 20:02
@jdx jdx enabled auto-merge (squash) November 20, 2024 20:20
@jdx jdx merged commit acdbc98 into main Nov 20, 2024
16 checks passed
@jdx jdx deleted the plugins-config branch November 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins config is useless when trying to override a core plugin
1 participant