Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals #41

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

christophermlewis
Copy link
Contributor

Changes to get Signals to work, though I accept my understanding of the API of the library limited.
Signals according to DBus docs that are a broadcast require no destination, so made a change there.

I need to tidy up what I've done and squash commits, but functionally it works.

Copy link
Owner

@jeanparpaillon jeanparpaillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I have not tested signals extensively :/

@@ -196,7 +196,8 @@ to_xmerl(#dbus_method{}=Elem) ->
end,
to_xmerl(Elem#dbus_method.args) ++ Result};

to_xmerl(#dbus_signal{}=Elem) ->
to_xmerl({_, #dbus_signal{}=Elem}) ->
?info("singal: ~p~n", [Elem#dbus_signal.name]),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singal -> signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants