Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode for galene interface #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RayBoucherit
Copy link

No description provided.

@MisterDA
Copy link
Contributor

There's a CSS media query for the color scheme ; the user sets that preference globally (in the browser or the OS). Galène can use it for the default color sheme.
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@jech
Copy link
Owner

jech commented Jun 9, 2021

@takdj ?

@takdj
Copy link
Contributor

takdj commented Jun 10, 2021

I think in this case, only color and background properties should be overwritten, for example:

.app-dark {
    background-color: #212529;
    box-shadow: 0 1px 1px 0 rgba(90, 89, 89, 0.06), 0 2px 5px 0 rgba(0, 0, 0, .2);
}

@jech jech force-pushed the master branch 2 times, most recently from 4f84b48 to 0d2ca28 Compare July 15, 2021 23:40
@jech
Copy link
Owner

jech commented Aug 7, 2021

@4h30, @takdj, what's the consensus on this?

@takdj
Copy link
Contributor

takdj commented Aug 9, 2021

the dark mode feature is good but for me, It's required to update patch to change only color and background properties on dark mode. Else maintaining css will become harder.
On javascript side, it's also better to set class 'app-dark' only on main div then, propagate dark style in css to children div.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants