Merge pull request #33 from jecisc/32-Improve-test-coverage-using-MuT…

…alk-mutation-testing

32-Improve-test-coverage-using-MuTalk-mutation-testing

.gitignore

@@ -20,3 +20,5 @@ SqueakDebug.log
 # Metacello-github cache
 /github-cache
 github-*.zip
+
+**/.DS_STORE

scripts/mutationTesting.st

@@ -0,0 +1,26 @@
+Metacello new
+    githubUser: 'jecisc' project: 'TinyLogger' commitish: 'v1.x.x' path: 'src';
+    baseline: 'TinyLogger';
+    load.
+
+Metacello new
+  baseline: 'MuTalk';
+  repository: 'github://pavel-krivanek/mutalk/src';
+  load.
+
+analysis := MutationTestingAnalysis
+    testCasesFrom: 'TinyLogger-Tests' asPackage definedClasses 
+    mutating: 'TinyLogger' asPackage definedClasses
+    using: MutantOperator contents
+    with: AllTestsMethodsRunningMutantEvaluationStrategy new.
+analysis run.
+alive := analysis generalResult aliveMutants.
+
+browser := GLMTabulator new.
+browser 
+    row: #results;
+    row: #diff.
+browser transmit to: #results.
+browser transmit to: #diff; from: #results; andShow: [ :a | 
+    a diff display: [ :mutant | {((RBParser parseMethod: (mutant mutant originalSource)) formattedCode) . ((RBParser parseMethod: (mutant mutant modifiedSource)) formattedCode)}] ].
+browser openOn: alive.

src/TinyLogger-Tests/TinyLoggerTest.class.st

@@ -90,6 +90,12 @@ TinyLoggerTest >> testClearLog [
 	self assert: (logger fileLoggers noneSatisfy: [ :fileLogger | fileLogger fileReference exists ])
 ]
 
+{ #category : #test }
+TinyLoggerTest >> testCurrentLogger [
+	self assert: TinyCurrentLogger value isNotNil.
+	self assert: TinyCurrentLogger value class equals: TinyLogger
+]
+
 { #category : #test }
 TinyLoggerTest >> testEnsureFileLogger [
 	logger removeAllLoggers.
@@ -160,6 +166,31 @@ TinyLoggerTest >> testExecuteRecordedAs [
 			stream close ]
 ]
 
+{ #category : #test }
+TinyLoggerTest >> testExecuteRecordedAs2 [
+	| contents stream |
+	self skipInPharo6.
+	logger
+		timestampFormatBlock: [ :s | s nextPutAll: 'No time' ];
+		removeAllLoggers;
+		addStdoutLogger.
+	stream := '' writeStream.
+	[ Stdio stub stdout willReturn: stream.
+	TinyCurrentLogger value: logger during: [ Object new execute: [ 'test' record ] recordedAs: 'This is a new test' ].
+	contents := Stdio stdout contents asString.
+
+	"Ensure we have the right indentation."
+	self
+		assert: contents withUnixLineEndings
+		equals:
+			'No time : 	Begin: This is a new test
+No time : 		test
+No time : 	End: This is a new test
+' withUnixLineEndings ]
+		ensure: [ Stdio recoverFromGHMutation.
+			stream close ]
+]
+
 { #category : #test }
 TinyLoggerTest >> testFileLoggers [
 	logger

src/TinyLogger/ManifestTinyLogger.class.st

@@ -13,13 +13,3 @@ Class {
 	#superclass : #PackageManifest,
 	#category : #'TinyLogger-Manifest'
 }
-
-{ #category : #'code-critics' }
-ManifestTinyLogger class >> ruleRBCodeCruftLeftInMethodsRuleV1FalsePositive [
-	^ #(#(#(#RGClassDefinition #(#TinyTranscriptLogger)) #'2018-11-25T02:59:41.364573+01:00') )
-]
-
-{ #category : #'code-critics' }
-ManifestTinyLogger class >> ruleRBCollectionMessagesToExternalObjectRuleV1FalsePositive [
-	^ #(#(#(#RGMethodDefinition #(#TinyLogger #addLogger: #false)) #'2018-11-25T20:54:01.067573+01:00') #(#(#RGMethodDefinition #(#TinyLogger #removeLogger: #false)) #'2018-11-25T20:54:59.231573+01:00') )
-]

src/TinyLogger/TinyAbstractLogger.class.st

@@ -26,6 +26,7 @@ Class {
 
 { #category : #testing }
 TinyAbstractLogger class >> isAbstract [
+	<ignoreForCoverage>
 	^ self = TinyAbstractLogger
 ]
 
@@ -48,5 +49,6 @@ TinyAbstractLogger >> record: aString [
 
 { #category : #accessing }
 TinyAbstractLogger >> timestampFormatBlock [
+	<ignoreForCoverage>
 	^ self subclassResponsibility
 ]

src/TinyLogger/TinyFileLogger.class.st

@@ -45,6 +45,7 @@ TinyFileLogger class >> for: aLogger named: aString [
 
 { #category : #accessing }
 TinyFileLogger class >> kind [
+	<ignoreForCoverage>
 	^ 'file'
 ]
 
@@ -84,7 +85,7 @@ TinyFileLogger >> fileReference [
 TinyFileLogger >> fileStreamDo: aBlock [
 	"For now we re-open the file all the time to avoid problems when we change its image of computer/OS or if the user delete the file. Maybe later we can find a better solution but in any case we should test such weird behaviors."
 
-	^ self fileReference
+	self fileReference
 		ensureCreateFile;
 		writeStreamDo: [ :s | 
 			s setToEnd.

src/TinyLogger/TinyLeafLogger.class.st

@@ -37,11 +37,13 @@ TinyLeafLogger class >> for: aTinyLogger [
 
 { #category : #testing }
 TinyLeafLogger class >> isAbstract [
+	<ignoreForCoverage>
 	^ self = TinyLeafLogger
 ]
 
 { #category : #accessing }
 TinyLeafLogger class >> kind [
+	<ignoreForCoverage>
 	^ self subclassResponsibility
 ]
 
@@ -67,7 +69,6 @@ TinyLeafLogger >> parentLogger [
 
 { #category : #accessing }
 TinyLeafLogger >> parentLogger: aLogger [
-	parentLogger == aLogger ifTrue: [ ^ self ].
 	parentLogger := aLogger
 ]
 

src/TinyLogger/TinyLogger.class.st

@@ -98,7 +98,7 @@ TinyLogger class >> default: anObject [
 
 { #category : #initialization }
 TinyLogger class >> reset [
-	^ self default: nil
+	self default: nil
 ]
 
 { #category : #'public API' }

src/TinyLogger/TinyStdoutLogger.class.st

@@ -22,6 +22,7 @@ Class {
 
 { #category : #accessing }
 TinyStdoutLogger class >> kind [
+	<ignoreForCoverage>
 	^ 'stdout'
 ]
 

src/TinyLogger/TinyTranscriptLogger.class.st

@@ -19,6 +19,7 @@ Class {
 
 { #category : #accessing }
 TinyTranscriptLogger class >> kind [
+	<ignoreForCoverage>
 	^ 'transcript'
 ]