Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: provide mechanism to tell the user that some operation failed #153

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

virtuald
Copy link
Contributor

@virtuald virtuald commented Apr 4, 2021

Proposed Changes

Provides MarkAsErrorDone() to let the user know that a failure occurred.

Fixes #151

cmd/demo-progress/demo.go Outdated Show resolved Hide resolved
progress/style.go Show resolved Hide resolved
progress/tracker.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 6, 2021

Coverage Status

Coverage decreased (-0.07%) to 99.931% when pulling 345225b on virtuald:progress-fail into ad9b9ed on jedib0t:master.

@jedib0t jedib0t merged commit 115daa3 into jedib0t:master Apr 6, 2021
@virtuald virtuald deleted the progress-fail branch April 7, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide mechanism to express an error for progress
3 participants