Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF8String instead of Pointer_stringify #198

Merged
merged 5 commits into from
May 21, 2019
Merged

Conversation

bas-d
Copy link
Contributor

@bas-d bas-d commented May 7, 2019

This is part of the fix for #196.

wrapper/build-wrappers.js Outdated Show resolved Hide resolved
@bas-d
Copy link
Contributor Author

bas-d commented May 9, 2019

I think the difference in drop_console is caused by side effects that originate in emscripten. Probably best to fix it properly there before merging these changes. Should work with either drop_console true or false. See emscripten-core/emscripten#8558

@bas-d
Copy link
Contributor Author

bas-d commented May 11, 2019

Ok turns out drop_console breaks things because of the way emscripten allows rebinding it with Module.print and Module.printErr. It can be easily fixed by explicitly rebinding these in emscripten.sh of the libsodium repo. I'll submit a PR there. I think we need this one as well because it gives a deprecation warning for Pointer_stringify otherwise.

@jennatuckerdeveloper
Copy link

Hi! Are the issues with this commit resolved at this point? It looks like the libsodium.js PR that came from this discussion has been merged.

@jedisct1 jedisct1 merged commit b9213d1 into jedisct1:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants