Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

New features for CLI #55

Merged
merged 1 commit into from
Mar 4, 2017
Merged

New features for CLI #55

merged 1 commit into from
Mar 4, 2017

Conversation

gucong3000
Copy link
Collaborator

- Added: default value for options <files...> #46
- Added: exclude binary file #45
- Modified:  use `console.error` instead of `console.log` to output error message
- Added: testcase for CLI
@codecov
Copy link

codecov bot commented Mar 4, 2017

Codecov Report

Merging #55 into master will increase coverage by 36.54%.
The diff coverage is 85%.

@@             Coverage Diff             @@
##           master      #55       +/-   ##
===========================================
+ Coverage   55.91%   92.46%   +36.54%     
===========================================
  Files          11       11               
  Lines         499      504        +5     
  Branches       94       97        +3     
===========================================
+ Hits          279      466      +187     
+ Misses        213       22      -191     
- Partials        7       16        +9
Impacted Files Coverage Δ
lib/cli.ts 85.24% <85%> (+85.24%)
lib/rules/indent_size.ts 100% <0%> (+5.88%)
lib/editor-config-error.ts 93.33% <0%> (+6.66%)
lib/eclint.ts 85.62% <0%> (+85.62%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fe421...d567cb2. Read the comment docs.

@jednano
Copy link
Owner

jednano commented Mar 4, 2017

Nicely done!

@jednano jednano merged commit b659ece into jednano:master Mar 4, 2017
@jednano
Copy link
Owner

jednano commented Mar 4, 2017

@gucong3000 anything else you want to add before I do a major release?

@gucong3000 gucong3000 deleted the cli_update branch March 5, 2017 02:20
@gucong3000
Copy link
Collaborator Author

gucong3000 commented Mar 5, 2017

anything else you want to add before I do a major release?

nothing.

@jednano jednano mentioned this pull request Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants