Add code to escape non-escaped spaces in arg paths #47
Conversation
Based on jedrichards/grunt-rsync#51, I've added code to rsyncwrapper which automatically escapes any space characters in file paths within rsyncwrapper's arguments. I've also added some rudimentary tests to verify that: - Copying from a single source path with space characters does not error, etc. - Copying from a single source path with spaces *to* a destination with spaces does not error, etc. - Passing in source and destination strings with already-escaped space character results in an identical rsync command This is only partial test coverage, but there is now at least one test failure when removing the new space-escaping code, so I believe it's a reasonable first pass.
|
This looks great, definitely going to merge this - thanks! Might need to make a few minor changes to your test process though - specifically that your new tests aren't cleaning up after themselves so could lead to some false positives I think? So the following changes are needed I think:
That should do it?
|
|
Ah, got it, sorry for the delayed reply. Will look into making those changes! |
In response to @jedrichards' comment on #47. Thanks Jed!
|
Alright, test-oriented fixes are in. |
|
👌 Thanks! Will cut a new major release for this... |
|
@jedrichards One favor: could you also please cut a release for grunt-rsync? That way I can specify a newer version of that package as a dependency on a few tools. Thank you! |
|
On it :) |
Based on jedrichards/grunt-rsync#51, I've added code to rsyncwrapper which automatically escapes any space characters in file paths within rsyncwrapper's arguments.
I've also added some rudimentary tests to verify that:
This is only partial test coverage, but there is now at least one test failure when removing the new space-escaping code, so I believe it's a reasonable first pass.