Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

[Doc] Add a notice in the doc about the fact that the Graph API version isn't specified by the plugin itself #708

Closed
peterpeterparker opened this issue Sep 13, 2018 · 7 comments
Assignees

Comments

@peterpeterparker
Copy link
Collaborator

[ X] I'm reporting a feature request

Describe the doc improvement

To follow #703 and the many questions, it would be good to add a notice in the doc that the plugin itself doesn't specify a Graph API version

@peterpeterparker
Copy link
Collaborator Author

I have added a note about the Graph API in the README (see commit b3efd52)

FYI @fredgalvao I tried to summarize your explanation in #703 thx again

@fredgalvao
Copy link
Collaborator

I found this, which might explain a lot: https://developers.facebook.com/docs/apps/versions/

@peterpeterparker
Copy link
Collaborator Author

@fredgalvao that would mean that without specifying version the older version is used per default, but we are still not sure if the Facebook SDK set a version or not no? or do you see that differently?

@fredgalvao
Copy link
Collaborator

My take on that is:

  • each Facebook SDK (Android, iOS or Javascript) comes with a predefined Graph API Version, and recent SDK versions have had the option to programmatically change that version to one older than the predefined. source@ https://developers.facebook.com/docs/apps/versions/ :

Each version of the Android SDK that's released is tied to the version that's available on the date of release. This means that if you're upgrading to a new SDK you're also upgrading to the latest API version as well (although you can manually specify any earlier, available API version with GraphRequest.setVersion()). The API version is listed with the release of each version of the Android SDK.

So, after so much time it seems I now understand those versions, the relationship between them, and how it affects me (and will do so in the next 21 days, how lucky am I).

And now, my conclusion/suggestion is the following:

  • I think we should start mirroring the iOS and Android SDKs (Facebook SDKs) to have the same version on each release, instead of the current model which is:
    • fixed Facebook iOS SDK version
    • dynamic greedy 4.+ Facebook iOS SDK version
  • with mirrored and fixed major+minor versions on each facebook4 release (like 4.36.+), we could pin-point which plugin release uses which graph API version, so that issues like these (with users asking "am I gonna be affected by the v2.7 removal?? please help!")

I suggest that because, with the 4.+ there we can never say which actual version users are using (it depends on when they installed the plugin, among other things). And thus we can never help users answer that type of issue.

@fredgalvao fredgalvao reopened this Sep 14, 2018
@peterpeterparker
Copy link
Collaborator Author

peterpeterparker commented Sep 15, 2018

@fredgalvao I'm agree with your conclusion and suggestions 👍

to reflect this I will:

  • Update the default value of FACEBOOK_ANDROID_SDK_VERSION to v4.36.0 (current Facebook iOS SDK) in config.xml
  • Clean the doc regarding this variable
  • Add a notice about the "mirroring"
  • Release of version v3.0.0 of the plugin (even if no major change, it's a change in the way to handle the next releases)

Agree or would you like to solve that differently?

@fredgalvao
Copy link
Collaborator

Seems pretty good to me!

@peterpeterparker
Copy link
Collaborator Author

Solved in commit b76b207 and published in v3.0.0

Thx @fredgalvao 👍

Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants