-
Notifications
You must be signed in to change notification settings - Fork 509
Fix openUrl handling bugs and add support for cordova-ios-5 #751
Conversation
oh, just saw this PR - we ran into exactly the same issue and also discovered the same solution. pLease merge this!! (or ours ;)) |
…d runtime crash when called.
facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock
This now also fixes #770 by updating facebook android AND ios sdks to version 5.0.2. |
@guylando I've installed your fork and am getting crash on iOS, looks like handling openURL never ends, I've got thousands of this message in xcode console before it crashes: any ideas how to fix? |
@igorkurochka did you do this #750 (comment) ? as written in installation instructions here https://github.com/guylando/cordova-plugin-facebook4#installation |
Hey maintainers :D Thanks! |
hey, I really need that pr too. |
@guylando installing this fork stucks.
What's the problem? Another npm-packages or cordova-plugins install normally. |
@vvarda this plugin is huge so it takes a lot of time, just leave it and go eat something |
thx @guylando for the amazing work 👍 |
* Update FacebookConnectPlugin.m Fix jeduan#750 * Update README.md * Upgraded facebook sdk to 5.0.2 * Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called. * Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850 * Modernized FBSDKLoginKit usage according to facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock * removed irrelevant files
* Update FacebookConnectPlugin.m Fix jeduan#750 * Update README.md * Upgraded facebook sdk to 5.0.2 * Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called. * Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850 * Modernized FBSDKLoginKit usage according to facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock * removed irrelevant files
* Update FacebookConnectPlugin.m Fix jeduan#750 * Update README.md * Upgraded facebook sdk to 5.0.2 * Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called. * Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850 * Modernized FBSDKLoginKit usage according to facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock * removed irrelevant files
* Update FacebookConnectPlugin.m Fix jeduan#750 * Update README.md * Upgraded facebook sdk to 5.0.2 * Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called. * Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850 * Modernized FBSDKLoginKit usage according to facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock * removed irrelevant files
Fix #750