Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build issue #56

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix(ci): build issue #56

merged 3 commits into from
Feb 27, 2024

Conversation

jeertmans
Copy link
Owner

Add Cargo.lock as recommended by PyO3/maturin#1960 (comment).

Maybe this will be worth removing once Maturin>1.4.0 is released.

Add Cargo.lock as recommended by PyO3/maturin#1960 (comment).

Maybe this will be worth removing once Maturin>1.4.0 is released.
@jeertmans jeertmans added the bug Something isn't working label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (8fb1820) to head (a5f6188).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files          14       14           
  Lines         385      385           
=======================================
  Hits          315      315           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.03     23.5±0.81ns 40.7 MElem/sec    1.00     22.7±0.10ns 41.9 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.9±0.20ns 29.0 MElem/sec    1.00     33.1±0.42ns 28.8 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.01   368.8±12.51ns 25.9 MElem/sec    1.00    364.1±6.31ns 26.2 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.4±0.02µs 39.4 MElem/sec    1.02      2.5±0.04µs 38.8 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.2±0.37µs 42.9 MElem/sec    1.00     22.1±0.11µs 43.1 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.02    232.0±2.29ns  4.1 MElem/sec    1.00    227.1±2.99ns  4.2 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.01    244.2±2.03ns  3.9 MElem/sec    1.00    240.9±1.74ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.00      2.6±0.02µs  3.7 MElem/sec    1.04      2.7±0.04µs  3.6 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.06     24.3±0.34µs  3.9 MElem/sec    1.00     23.0±0.23µs  4.2 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    229.2±2.05µs  4.2 MElem/sec    1.08    247.4±2.12µs  3.9 MElem/sec

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Python benchmark results:


------------------------------------------------- benchmark: 12 tests --------------------------------------------------
Name (time in us)                                              Mean             StdDev            OPS (Kops/s)          
------------------------------------------------------------------------------------------------------------------------
test_generate_all_path_candidates[0-0] (0002_pgo)          171.9228 (1.01)     12.4857 (1.55)           5.8166 (0.99)   
test_generate_all_path_candidates[1-1] (0002_pgo)          170.6230 (1.0)      10.2395 (1.27)           5.8609 (1.0)    
test_generate_all_path_candidates[0-0] (0001_changes)      174.2367 (1.02)     13.4895 (1.68)           5.7393 (0.98)   
test_generate_all_path_candidates[1-1] (0001_changes)      175.7770 (1.03)     14.2439 (1.77)           5.6890 (0.97)   
test_generate_all_path_candidates[1-1] (0003_before)       173.3256 (1.02)      9.0023 (1.12)           5.7695 (0.98)   
test_generate_all_path_candidates[0-0] (0003_before)       174.3214 (1.02)      8.0372 (1.0)            5.7365 (0.98)   
test_generate_all_path_candidates[4-5] (0002_pgo)          181.8645 (1.07)      8.6116 (1.07)           5.4986 (0.94)   
test_generate_all_path_candidates[4-5] (0001_changes)      185.2438 (1.09)     12.8152 (1.59)           5.3983 (0.92)   
test_generate_all_path_candidates[4-5] (0003_before)       186.4821 (1.09)      8.3384 (1.04)           5.3624 (0.91)   
test_generate_all_path_candidates[10-3] (0002_pgo)         192.3635 (1.13)     11.4448 (1.42)           5.1985 (0.89)   
test_generate_all_path_candidates[10-3] (0001_changes)     195.8418 (1.15)      9.1599 (1.14)           5.1062 (0.87)   
test_generate_all_path_candidates[10-3] (0003_before)      196.6715 (1.15)      8.7286 (1.09)           5.0846 (0.87)   
------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0003_before)      371.9549 (1.13)     113.9731 (3.40)           2.6885 (0.89)   
test_complete_graph_all_paths (0001_changes)     380.0241 (1.15)     829.9764 (24.77)          2.6314 (0.87)   
test_complete_graph_all_paths (0002_pgo)         329.6478 (1.0)       33.5045 (1.0)            3.0335 (1.0)    
---------------------------------------------------------------------------------------------------------------

----------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests ------------------------------------
Name (time in ns)                                                       Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0002_pgo)          28.4277 (1.0)        129.2320 (1.23)          35.1769 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      31.2286 (1.10)       188.5704 (1.80)          32.0219 (0.91)   
test_complete_graph_all_paths_array_chunks[1000] (0003_before)       30.4890 (1.07)       142.0780 (1.35)          32.7988 (0.93)   
test_complete_graph_all_paths_array_chunks[100] (0002_pgo)           36.6340 (1.29)       105.0446 (1.0)           27.2970 (0.78)   
test_complete_graph_all_paths_array_chunks[100] (0003_before)        39.5214 (1.39)       188.1772 (1.79)          25.3028 (0.72)   
test_complete_graph_all_paths_array_chunks[100] (0001_changes)       40.0912 (1.41)       243.4639 (2.32)          24.9431 (0.71)   
test_complete_graph_all_paths_array_chunks[10] (0002_pgo)            67.5683 (2.38)       184.6493 (1.76)          14.7998 (0.42)   
test_complete_graph_all_paths_array_chunks[10] (0003_before)         77.7986 (2.74)       268.3639 (2.55)          12.8537 (0.37)   
test_complete_graph_all_paths_array_chunks[10] (0001_changes)        76.6772 (2.70)       201.1800 (1.92)          13.0417 (0.37)   
test_complete_graph_all_paths_array_chunks[1] (0002_pgo)            332.8611 (11.71)    1,179.5506 (11.23)          3.0043 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0001_changes)        342.0789 (12.03)      880.9226 (8.39)           2.9233 (0.08)   
test_complete_graph_all_paths_array_chunks[1] (0003_before)         341.0722 (12.00)      777.5093 (7.40)           2.9319 (0.08)   
------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests --------------------------------------
Name (time in ns)                                                                     Mean                StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0002_pgo)         236.0806 (1.0)         24.7482 (2.32)           4.2358 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0002_pgo)          254.9345 (1.08)        23.5464 (2.21)           3.9226 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_before)      253.0003 (1.07)        10.6464 (1.0)            3.9526 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0001_changes)      272.0035 (1.15)        36.7246 (3.45)           3.6764 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0003_before)       268.3051 (1.14)        27.4874 (2.58)           3.7271 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0001_changes)     254.3633 (1.08)        16.9065 (1.59)           3.9314 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0002_pgo)           315.7307 (1.34)       114.9325 (10.80)          3.1673 (0.75)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0001_changes)       336.3273 (1.42)       122.4724 (11.50)          2.9733 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_before)        336.2133 (1.42)        87.3095 (8.20)           2.9743 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0002_pgo)            653.5045 (2.77)       507.6251 (47.68)          1.5302 (0.36)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_before)         694.0400 (2.94)     1,056.7276 (99.26)          1.4408 (0.34)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0001_changes)        701.5202 (2.97)     1,092.5894 (102.62)         1.4255 (0.34)   
--------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                                  Mean              StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0002_pgo)         627.7106 (1.0)      580.5601 (1.0)            1.5931 (1.0)    
test_di_graph_from_complete_graph_all_paths (0001_changes)     673.5325 (1.07)     624.3028 (1.08)           1.4847 (0.93)   
test_di_graph_from_complete_graph_all_paths (0003_before)      682.7714 (1.09)     890.1091 (1.53)           1.4646 (0.92)   
-----------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@jeertmans jeertmans merged commit c124235 into main Feb 27, 2024
45 checks passed
@jeertmans jeertmans deleted the fix-build-issue branch February 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant