Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): maturin was fixed #67

Merged
merged 1 commit into from
Mar 10, 2024
Merged

chore(ci): maturin was fixed #67

merged 1 commit into from
Mar 10, 2024

Conversation

jeertmans
Copy link
Owner

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (7968c24) to head (9cd4f59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          14       14           
  Lines         469      469           
=======================================
  Hits          393      393           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.01     22.5±0.19ns 42.3 MElem/sec    1.00     22.3±0.45ns 42.8 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     33.0±0.23ns 28.9 MElem/sec    1.00     32.9±0.23ns 29.0 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.00    383.3±6.12ns 24.9 MElem/sec    1.01    386.8±6.81ns 24.7 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.6±0.07µs 36.9 MElem/sec    1.01      2.6±0.05µs 36.6 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.6±0.13µs 42.2 MElem/sec    1.00     22.6±0.15µs 42.2 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.01    235.7±1.72ns  4.0 MElem/sec    1.00    232.4±3.32ns  4.1 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.01    240.2±3.50ns  4.0 MElem/sec    1.00    238.8±1.82ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.02      2.7±0.05µs  3.6 MElem/sec    1.00      2.6±0.02µs  3.6 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.05     24.2±0.49µs  3.9 MElem/sec    1.00     23.1±0.17µs  4.1 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    228.1±1.61µs  4.2 MElem/sec    1.10    250.6±1.96µs  3.8 MElem/sec

Copy link
Contributor

Python benchmark results:


------------------------------------------------- benchmark: 12 tests --------------------------------------------------
Name (time in us)                                              Mean             StdDev            OPS (Kops/s)          
------------------------------------------------------------------------------------------------------------------------
test_generate_all_path_candidates[0-0] (0002_pgo)           93.6513 (1.01)      7.0282 (1.50)          10.6779 (0.99)   
test_generate_all_path_candidates[1-1] (0002_pgo)           92.8344 (1.0)       4.6978 (1.0)           10.7719 (1.0)    
test_generate_all_path_candidates[0-0] (0001_changes)       93.9739 (1.01)      5.1257 (1.09)          10.6413 (0.99)   
test_generate_all_path_candidates[0-0] (0003_before)        94.2462 (1.02)      5.4706 (1.16)          10.6105 (0.99)   
test_generate_all_path_candidates[1-1] (0003_before)        94.5949 (1.02)      5.2273 (1.11)          10.5714 (0.98)   
test_generate_all_path_candidates[1-1] (0001_changes)       95.7136 (1.03)      8.0388 (1.71)          10.4478 (0.97)   
test_generate_all_path_candidates[4-5] (0002_pgo)          104.3596 (1.12)     10.0567 (2.14)           9.5823 (0.89)   
test_generate_all_path_candidates[4-5] (0003_before)       105.1241 (1.13)      5.9968 (1.28)           9.5126 (0.88)   
test_generate_all_path_candidates[4-5] (0001_changes)      106.3956 (1.15)      7.3530 (1.57)           9.3989 (0.87)   
test_generate_all_path_candidates[10-3] (0002_pgo)         114.8451 (1.24)      8.7773 (1.87)           8.7074 (0.81)   
test_generate_all_path_candidates[10-3] (0003_before)      114.5354 (1.23)      5.0868 (1.08)           8.7309 (0.81)   
test_generate_all_path_candidates[10-3] (0001_changes)     120.0438 (1.29)     10.7984 (2.30)           8.3303 (0.77)   
------------------------------------------------------------------------------------------------------------------------

------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean             StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0001_changes)     375.0010 (1.13)     99.8920 (4.05)           2.6667 (0.88)   
test_complete_graph_all_paths (0003_before)      372.4524 (1.13)     89.1399 (3.61)           2.6849 (0.89)   
test_complete_graph_all_paths (0002_pgo)         330.8834 (1.0)      24.6814 (1.0)            3.0222 (1.0)    
--------------------------------------------------------------------------------------------------------------

----------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests ------------------------------------
Name (time in ns)                                                       Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0002_pgo)          29.1537 (1.0)        196.8131 (1.77)          34.3010 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      31.3847 (1.08)       186.3246 (1.68)          31.8627 (0.93)   
test_complete_graph_all_paths_array_chunks[1000] (0003_before)       30.5967 (1.05)       137.7581 (1.24)          32.6833 (0.95)   
test_complete_graph_all_paths_array_chunks[100] (0002_pgo)           36.2515 (1.24)       111.1697 (1.0)           27.5851 (0.80)   
test_complete_graph_all_paths_array_chunks[100] (0001_changes)       39.6204 (1.36)       199.8852 (1.80)          25.2395 (0.74)   
test_complete_graph_all_paths_array_chunks[100] (0003_before)        39.5357 (1.36)       184.2988 (1.66)          25.2936 (0.74)   
test_complete_graph_all_paths_array_chunks[10] (0002_pgo)            68.5158 (2.35)       221.1958 (1.99)          14.5952 (0.43)   
test_complete_graph_all_paths_array_chunks[10] (0003_before)         75.6388 (2.59)       258.3582 (2.32)          13.2207 (0.39)   
test_complete_graph_all_paths_array_chunks[10] (0001_changes)        77.2119 (2.65)       200.8919 (1.81)          12.9514 (0.38)   
test_complete_graph_all_paths_array_chunks[1] (0002_pgo)            335.1577 (11.50)    1,660.2836 (14.93)          2.9837 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0001_changes)        340.2352 (11.67)    1,069.6333 (9.62)           2.9391 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0003_before)         337.7377 (11.58)      792.9736 (7.13)           2.9609 (0.09)   
------------------------------------------------------------------------------------------------------------------------------------

------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests -------------------------------------
Name (time in ns)                                                                     Mean              StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0002_pgo)          253.5857 (1.08)      22.0836 (2.87)           3.9434 (0.92)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0002_pgo)         233.9508 (1.0)        8.2488 (1.07)           4.2744 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0001_changes)     246.3574 (1.05)      12.6953 (1.65)           4.0591 (0.95)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0003_before)       266.0531 (1.14)      23.9013 (3.11)           3.7586 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0001_changes)      264.9730 (1.13)      21.9912 (2.86)           3.7740 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_before)      256.1555 (1.09)       7.6877 (1.0)            3.9039 (0.91)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0002_pgo)           313.3025 (1.34)     108.5974 (14.13)          3.1918 (0.75)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0001_changes)       325.0437 (1.39)     107.1974 (13.94)          3.0765 (0.72)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_before)        336.1476 (1.44)      84.0261 (10.93)          2.9749 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0002_pgo)            649.3276 (2.78)     975.6643 (126.91)         1.5401 (0.36)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0001_changes)        671.8633 (2.87)     601.5546 (78.25)          1.4884 (0.35)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_before)         668.6550 (2.86)     638.1611 (83.01)          1.4955 (0.35)   
------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests ---------------------------------
Name (time in ns)                                                  Mean                StdDev            OPS (Mops/s)          
-------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0002_pgo)         609.5634 (1.0)      1,005.9465 (2.15)           1.6405 (1.0)    
test_di_graph_from_complete_graph_all_paths (0001_changes)     666.4181 (1.09)     1,017.9843 (2.17)           1.5006 (0.91)   
test_di_graph_from_complete_graph_all_paths (0003_before)      670.0091 (1.10)       468.9393 (1.0)            1.4925 (0.91)   
-------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@jeertmans jeertmans merged commit b1ea335 into main Mar 10, 2024
34 of 44 checks passed
@jeertmans jeertmans deleted the mathurin-fix branch March 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant