Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct the module path #371

Merged
merged 2 commits into from
Aug 31, 2022
Merged

build: correct the module path #371

merged 2 commits into from
Aug 31, 2022

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Aug 31, 2022

For a published module, we should use repo's url as the module path, so we can download or refer it by go module.

And for we are in v4.x, so we should add the /v4 suffix to the module path.

Reference

https://go.dev/doc/tutorial/create-module#start:

Run the go mod init command, giving it your module path -- here, use example.com/greetings. If you publish a module, this must be a path from which your module can be downloaded by Go tools. That would be your code's repository.

Now we are in v4.x, the `/v4` suffix should be added.
@jeessy2 jeessy2 merged commit d982b05 into jeessy2:master Aug 31, 2022
@jeessy2
Copy link
Owner

jeessy2 commented Aug 31, 2022

thanks

@yin1999 yin1999 deleted the fix-module branch August 31, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants