Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GoDaddy): use @ as name when subdomain is missing #770

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(GoDaddy): use @ as name when subdomain is missing #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/domains.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (d Domain) GetFullDomain() string {
}

// GetSubDomain 获得子域名，为空返回@
// 阿里云/腾讯云/dnspod/namecheap 需要
// 阿里云/腾讯云/dnspod/GoDaddy/namecheap 需要
func (d Domain) GetSubDomain() string {
if d.SubDomain != "" {
return d.SubDomain
Expand Down
4 changes: 2 additions & 2 deletions dns/godaddy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (g *GoDaddyDNS) updateDomainRecord(recordType string, ipAddr string, domain
for _, domain := range domains {
err := g.sendReq(http.MethodPut, recordType, domain, &godaddyRecords{godaddyRecord{
Data: ipAddr,
Name: domain.SubDomain,
Name: domain.GetSubDomain(),
TTL: g.ttl,
Type: recordType,
}})
Expand Down Expand Up @@ -107,7 +107,7 @@ func (g *GoDaddyDNS) sendReq(method string, rType string, domain *config.Domain,
}
}
path := fmt.Sprintf("https://api.godaddy.com/v1/domains/%s/records/%s/%s",
domain.DomainName, rType, domain.SubDomain)
domain.DomainName, rType, domain.GetSubDomain())

req, err := http.NewRequest(method, path, body)
if err != nil {
Expand Down