Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reactjs + javascript unit tests #3087

Closed
jeff1evesque opened this issue Oct 28, 2017 · 72 comments
Closed

Implement reactjs + javascript unit tests #3087

jeff1evesque opened this issue Oct 28, 2017 · 72 comments

Comments

@jeff1evesque
Copy link
Owner

jeff1evesque commented Oct 28, 2017

We need to write some initial reactjs + javascript unit tests, and integrate it into our travis ci builds.

Note: this issue will leverage the results found from #3084.

@jeff1evesque
Copy link
Owner Author

jeff1evesque commented Feb 11, 2018

We'll begin by creating snapshot tests. This means snapshot tests will be saved within test/jest/test/. After finishing writing the snapshot tests, when we run npm test, or jest, our snapshots will be created under test/__snapshots__/xxx, where xxx would be the corresponding snapshot filename. These snapshots should be committed into this issue. Additionally, we'll need to integrate the jest results, with our current code coverage implementation. So, the corresponding jest coverage results, will need to be merged with our existing pytest coverage.

@jeff1evesque
Copy link
Owner Author

Now, we can begin to write our snapshot tests, into the designated directory, and fix any docker related syntax, as well as making necessary adjustments to capture, and copy the corresponding coverage results. Assuming that the docker syntax is correct (both in unit-tests, as well as the respective dockerfiles), we'll need to find out how to merge the pytest results, with the jest coverage.

@jeff1evesque
Copy link
Owner Author

da6a87e: we install jest globally, so it'll be in the PATH, and can easily be used via our dockerfile.

jeff1evesque added a commit that referenced this issue May 29, 2018
jeff1evesque added a commit that referenced this issue May 29, 2018
jeff1evesque added a commit that referenced this issue May 31, 2018
jeff1evesque added a commit that referenced this issue May 31, 2018
#3087: Implement reactjs + javascript unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants