-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Timeout error message should include remaining resources in the message #72
Comments
@jmealo yes, that is a good idea, that way it goes back with the error. Currently if you enable logging you will see a log message with the remaining resources, but it would be nice to have it as part of the error too. So yes, if you want to create a PR that would be wonderful. Thanks! |
@jeffbski-rga: Thanks for the quick response: #73 is a PR implementing this. I took a few stabs at this to keep the current behavior unchanged. Presently, stack traces are output for non-timeout errors (which is desirable). Stack traces for timeouts are not helpful as they point to some rxjs internals, so I'm omitting them to match current behavior. |
Expose the remaining resources in timeout error messages (#72)
It would be great if the error returned when a timeout occurs included the output of
determineRemainingResources
in the message (or as a property). If you'd like I can do a PR for either/or.Thanks,
Jeff
The text was updated successfully, but these errors were encountered: