event args constructors made public to allow external code to call it #10
Conversation
|
Generally speaking I think this is considered bad practice. Can you explain why something external to the library need to create events? |
|
running the library with debugger attached spins up 1 cpu at 100% load and slows packets down, so i'm using a custom deserializer, but i would like to keep using most of the library, like packages definition and events to be able to swap it without code change. |
|
Why is the utilization so high? That’s not right
—
If you want to build a ship, don't drum up people to collect wood and don't assign them tasks and work, but rather teach them to long for the endless immensity of the sea.
Antoine de Saint-Exupery
…________________________________
From: Valeriob <notifications@github.com>
Sent: Sunday, February 25, 2018 5:12:37 AM
To: jefffhaynes/ublox
Cc: Jeff Haynes; Comment
Subject: Re: [jefffhaynes/ublox] event args constructors made public to allow external code to call it (#10)
running the library with debugger attached spins up 1 cpu at 100% load and slows packets down, so i'm using a custom deserializer, but i would like to keep using most of the library, like packages definition and events to be able to swap it without code change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#10 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJSKR7YDZByLZRRDWmMifRHhj5wVfWKdks5tYTIVgaJpZM4SPamI>.
|
|
Agree, but I don't have time to diagnose the serialization library right now. |
|
Can you tell me what you're doing that causes the behavior? I can try to
track it down.
…On Sun, Feb 25, 2018 at 8:08 AM, Valeriob ***@***.***> wrote:
Agree, but I don't have time to diagnose the serialization library right
now.
Let me use a custom one until we can diagnose the problem, I don't see any
issue on exposing those constructors
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJSKRwKbcXd5TlrfkMfhc_3GzKZedpi1ks5tYVtTgaJpZM4SPamI>
.
--
If you want to build a ship, don't drum up people together to collect wood
and don't assign them tasks and work, but rather teach them to long for the
endless immensity of the sea.
Antoine de Saint-Exupery
|
|
Just reading from a ublox device that outputs 3 message types with very low frequency, I'll prepare a repro as soon as I can. For now can you just help me be compatible ? |
|
I've run all performance tests on the serializer and everything seems
fine. Are you sure it isn't something else that's driving the utilization?
I'm very reluctant to make something public that shouldn't be. Even if
only a few people are using the library, making something public means that
making it private later on is an issue. I suggest branching it until you
can send something to help debug what it is you're seeing.
Thanks
…On Sun, Feb 25, 2018 at 9:08 AM, Valeriob ***@***.***> wrote:
Just reading from a ublox device that outputs 3 message types with very
low frequency, I'll prepare a repro as soon as I can. For now can you just
help me be compatible ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJSKRyhzIgFk78jp7e8IteXJpDh7wLkSks5tYWl6gaJpZM4SPamI>
.
--
If you want to build a ship, don't drum up people together to collect wood
and don't assign them tasks and work, but rather teach them to long for the
endless immensity of the sea.
Antoine de Saint-Exupery
|
|
Have you run the test with debugger attached ? |
|
It's slower but not unreasonably so and I don't see high CPU usage. That
being said, it's possible I'm not testing the right thing.
…On Sun, Feb 25, 2018 at 9:30 AM, Valeriob ***@***.***> wrote:
Have you run the test with debugger attached ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJSKR-_uG8EtJo5v9IC48VTugigAIjGWks5tYW58gaJpZM4SPamI>
.
--
If you want to build a ship, don't drum up people together to collect wood
and don't assign them tasks and work, but rather teach them to long for the
endless immensity of the sea.
Antoine de Saint-Exupery
|
|
I've prepared a repro: My device sends 👍 UBX NAV-PVT, UBX NAV-SVINFO, UBX NAV-STATUS, UBX NAV-RELPOSNED. |
|
hi @jefffhaynes could you check on it ? |
|
Sorry, I've been quite busy. I'll try to figure out what's causing the
slowdown but I would rather solve the underlying problem than doing a
workaround.
…On Fri, Mar 16, 2018 at 6:46 AM, Valeriob ***@***.***> wrote:
hi @jefffhaynes <https://github.com/jefffhaynes> could you check on it ?
can you please make those constructor public so we can reuse all the work
of the spec ?
thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJSKR-6_ctEbq9ikXGPFsS9o0V9_6JFVks5te5fygaJpZM4SPamI>
.
--
If you want to build a ship, don't drum up people together to collect wood
and don't assign them tasks and work, but rather teach them to long for the
endless immensity of the sea.
Antoine de Saint-Exupery
|
|
I understand what you mean @jefffhaynes , but that's not a work around, it's a feature. |
No description provided.