Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #283 #309

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix #283 #309

merged 2 commits into from
Jan 17, 2024

Conversation

ArtrenH
Copy link
Contributor

@ArtrenH ArtrenH commented Jan 1, 2024

The method getDomainsdoes not exist on the panel object in newer versions of filament. Therefore, installing breezy throws an error and makes the plugin unusable.
The new method name is getDomain. With this function, the installation process runs smoothly and the library is usable again.

@jeffgreco13 jeffgreco13 merged commit cad428d into jeffgreco13:2.x Jan 17, 2024
@jeffgreco13 jeffgreco13 mentioned this pull request Jan 17, 2024
@jeffgreco13
Copy link
Owner

@ArtrenH can you please explain further?
Using Filament v3.2.2 the method I see is still getDomains()

@ArtrenH
Copy link
Contributor Author

ArtrenH commented Jan 17, 2024

Running my laravel server without the patch, I get this error:
image
Other people seem to have the same problem:
filamentphp/filament#8054
#283
https://www.answeroverflow.com/m/1140422984771846288

I am on filament version 3.0 though and it seems that this is a me-problem and it seems to be fixed in the latest version:
https://github.com/filamentphp/filament/blame/3.x/packages/panels/src/Panel/Concerns/HasRoutes.php#L127

@jeffgreco13
Copy link
Owner

Are you sure you're on the latest version of Filament? Earlier versions of Filament v3 had getDomains() but it was updated to getDomains().

Either way, Breezy must have a dependency issue if composer is installing incorrect versions. I'll have to look at this, but in the meantime please ensure you're on the latest version of Filament or at least v3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants