Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable transitive pins and bump System.Text.Json #306

Closed

Conversation

MattKotsenas
Copy link
Contributor

Fix broken build due to NU1903.

To do so I:

  1. Enabled transitive pinning
  2. Bumped System.Text.Json to 6.0.10 for .NET 6.0
  3. Bumped System.Text.Json to 8.0.5 for all other TFMs

This mirrors the existing logic, but it isn't entirely clear to me why it was this way to begin with.

Comparing packages before and after, the version is bumped as expected (and no other package dependencies change) except the .NET 6.0 TFM now has a dependency on System.Text.Json.

@MattKotsenas
Copy link
Contributor Author

Here's the side-by-side (Old vs. New) in NuGet Package Explorer for this change

image

You know this area much better than me, so feel free to do what you please. Just helping out where I can since I already have the project open :)

@MattKotsenas
Copy link
Contributor Author

Same as #305, so pick which one you like better and close the other one ;)

@jeffkl
Copy link
Owner

jeffkl commented Oct 18, 2024

I'm not ready for transitive pinning just yet 😄

@jeffkl jeffkl closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants