[device_info] Fix pedantic errors (flutter#2314)

jefflim-google · Dec 3, 2019 · 408863d · 408863d
1 parent 118c29f
commit 408863d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 13 deletions.
diff --git a/packages/device_info/CHANGELOG.md b/packages/device_info/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.4.1+3
+
+* Fix pedantic errors. Adds some missing documentation and fixes unawaited
+  futures in the tests.
+
 ## 0.4.1+2
 
 * Remove AndroidX warning.

diff --git a/packages/device_info/analysis_options.yaml b/packages/device_info/analysis_options.yaml
diff --git a/packages/device_info/example/lib/main.dart b/packages/device_info/example/lib/main.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// ignore_for_file: public_member_api_docs
+
 import 'dart:async';
 
 import 'dart:io';

diff --git a/packages/device_info/example/test_driver/device_info_e2e_test.dart b/packages/device_info/example/test_driver/device_info_e2e_test.dart
@@ -10,6 +10,6 @@ Future<void> main() async {
   final FlutterDriver driver = await FlutterDriver.connect();
   final String result =
       await driver.requestData(null, timeout: const Duration(minutes: 1));
-  driver.close();
+  await driver.close();
   exit(result == 'pass' ? 0 : 1);
 }
diff --git a/packages/device_info/lib/device_info.dart b/packages/device_info/lib/device_info.dart
@@ -8,6 +8,8 @@ import 'package:flutter/services.dart';
 
 /// Provides device and operating system information.
 class DeviceInfoPlugin {
+  /// No work is done when instantiating the plugin. It's safe to call this
+  /// repeatedly or in performance-sensitive blocks.
   DeviceInfoPlugin();
 
   /// Channel used to communicate to native code.

diff --git a/packages/device_info/pubspec.yaml b/packages/device_info/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin providing detailed information about the device
   (make, model, etc.), and Android or iOS version the app is running on.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/device_info
-version: 0.4.1+2
+version: 0.4.1+3
 
 flutter:
   plugin: