Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy urls #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix proxy urls #306

wants to merge 2 commits into from

Conversation

nitrag
Copy link

@nitrag nitrag commented Jan 27, 2024

This fixes URLs when derbynet-server is hosted on one server and served by a different (proxy) server (NGINX).

jeffpiazza
jeffpiazza reviewed Jan 31, 2024
View reviewed changes
Copy link
Owner

@jeffpiazza jeffpiazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP_HOST may or may not be populated, depending on the server, so could you please add an isset test for that index, too?

Also, a nit: "accommodate"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpiazza jeffpiazza jeffpiazza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrag @jeffpiazza